Re: [PATCH] KVM: arm64: vgic: Remove duplicate check in update_affinity_collection()

From: Gavin Shan
Date: Sun Sep 25 2022 - 19:21:28 EST


Hi Marc,

On 9/24/22 9:56 PM, Marc Zyngier wrote:
Side note: please make sure you always Cc all the KVM/arm64 reviewers
when sending patches (now added).


Sure. The reason, why I didn't run './scripts/get_maintainer.pl' to get
all reviewers, is the patch is super simple one :)

On Fri, 23 Sep 2022 07:54:47 +0100,
Gavin Shan <gshan@xxxxxxxxxx> wrote:

The ITS collection is guranteed to be !NULL when update_affinity_collection()
is called. So we needn't check ITE's collection with NULL because the
check has been included to the later one.

It took me a while to understand what you meant by this: the 'coll'
parameter to update_affinity_collection() is never NULL, so comparing
it with 'ite->collection' is enough to cover both the NULL case and
the "another collection" case.

If you agree with this, I can directly fix the commit message when
applying the patch.


Yes, the commit message is accurate and correct. Please help to apply
your commit message directly :)

Thanks,
Gavin