Re: [PATCH] KVM: arm64: vgic: Remove duplicate check in update_affinity_collection()

From: Marc Zyngier
Date: Sat Sep 24 2022 - 07:57:13 EST


Gavin,

Side note: please make sure you always Cc all the KVM/arm64 reviewers
when sending patches (now added).

On Fri, 23 Sep 2022 07:54:47 +0100,
Gavin Shan <gshan@xxxxxxxxxx> wrote:
>
> The ITS collection is guranteed to be !NULL when update_affinity_collection()
> is called. So we needn't check ITE's collection with NULL because the
> check has been included to the later one.

It took me a while to understand what you meant by this: the 'coll'
parameter to update_affinity_collection() is never NULL, so comparing
it with 'ite->collection' is enough to cover both the NULL case and
the "another collection" case.

If you agree with this, I can directly fix the commit message when
applying the patch.

Thanks,

M.

--
Without deviation from the norm, progress is not possible.