Re: [PATCH v6] cpufreq: amd-pstate: cleanup the unused and duplicated headers declaration

From: Viresh Kumar
Date: Thu Sep 01 2022 - 03:01:51 EST


On 01-09-22, 06:56, Yuan, Perry wrote:
> > On 01-09-22, 14:23, Perry Yuan wrote:
> > > Cleanup the headers declaration which are not used actually and
> >
> > This is okay.
>
> Thank you help to confirm this .
>
> >
> > > some duplicated declaration which is declarated in some other headers
> > > already, it will help to simplify the header part.
> >
> > This isn't.
> >
> > Every file should directly include headers they use definitions from, instead of
> > relying on indirect inclusions.
> >
> > --
> > Viresh
>
> Do I need to update the commit with another V7 version ?

I am not sure which headers you removed are still required, working
for now since included indirectly. If there are any, then better to
get a new version out.

--
viresh