RE: [PATCH v6] cpufreq: amd-pstate: cleanup the unused and duplicated headers declaration

From: Yuan, Perry
Date: Thu Sep 01 2022 - 02:56:52 EST


[AMD Official Use Only - General]

Hi Viresh,

> -----Original Message-----
> From: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
> Sent: Thursday, September 1, 2022 2:32 PM
> To: Yuan, Perry <Perry.Yuan@xxxxxxx>
> Cc: rafael.j.wysocki@xxxxxxxxx; Huang, Ray <Ray.Huang@xxxxxxx>; Sharma,
> Deepak <Deepak.Sharma@xxxxxxx>; Limonciello, Mario
> <Mario.Limonciello@xxxxxxx>; Fontenot, Nathan
> <Nathan.Fontenot@xxxxxxx>; Deucher, Alexander
> <Alexander.Deucher@xxxxxxx>; Su, Jinzhou (Joe) <Jinzhou.Su@xxxxxxx>;
> Huang, Shimmer <Shimmer.Huang@xxxxxxx>; Du, Xiaojian
> <Xiaojian.Du@xxxxxxx>; Meng, Li (Jassmine) <Li.Meng@xxxxxxx>; linux-
> pm@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v6] cpufreq: amd-pstate: cleanup the unused and
> duplicated headers declaration
>
> [CAUTION: External Email]
>
> On 01-09-22, 14:23, Perry Yuan wrote:
> > Cleanup the headers declaration which are not used actually and
>
> This is okay.

Thank you help to confirm this .

>
> > some duplicated declaration which is declarated in some other headers
> > already, it will help to simplify the header part.
>
> This isn't.
>
> Every file should directly include headers they use definitions from, instead of
> relying on indirect inclusions.
>
> --
> Viresh

Do I need to update the commit with another V7 version ?
If need, I will update this later.

Thank you.

Perry.