Re: [PATCH v14 5/5] arm64: dts: qcom: sc7180: Add kingoftown dts files

From: Doug Anderson
Date: Mon Jun 27 2022 - 10:01:56 EST


Hi,

On Sat, Jun 25, 2022 at 6:40 PM Joseph S. Barrera III
<joebar@xxxxxxxxxxxx> wrote:
>
> Kingoftown is a trogdor-based board. These dts files are unchanged copies
> from the downstream Chrome OS 5.4 kernel.
>
> Signed-off-by: Joseph S. Barrera III <joebar@xxxxxxxxxxxx>
> ---
>
> (no changes since v11)
>
> Changes in v11:
> - Add 'include sc7180-trogdor.dtsi' to sc7180-trogdor-kingoftown-* files.
>
> Changes in v10:
> - Remove 'include sc7180.dtsi' from *all* sc7180-trogdor-kingoftown* files.
>
> Changes in v9:
> - Simplify trackpad enabling (51d30402be75).
>
> Changes in v7:
> - Simplify spi0/spi6 labeling (d277cab7afc7).
> - Remove #include of <arm/cros-ec-keyboard.dtsi>.
>
> Changes in v6:
> - Add #include of <arm/cros-ec-keyboard.dtsi> from v5.4.
>
> Changes in v4:
> - Fix description (no downstream bits removed).
> - Add missing version history.
>
> Changes in v2:
> - First inclusion in series.
>
> arch/arm64/boot/dts/qcom/Makefile | 2 +
> .../dts/qcom/sc7180-trogdor-kingoftown-r0.dts | 44 ++++
> .../dts/qcom/sc7180-trogdor-kingoftown-r1.dts | 17 ++
> .../dts/qcom/sc7180-trogdor-kingoftown.dtsi | 225 ++++++++++++++++++
> 4 files changed, 288 insertions(+)
> create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown-r0.dts
> create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown-r1.dts
> create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown.dtsi

Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>

I put this on a google,kingoftown-rev2-sku0 and confirmed that it at
least booted up and showed stuff on the screen.

Tested-by: Douglas Anderson <dianders@xxxxxxxxxxxx>