Re: [PATCH v14 4/5] arm64: dts: qcom: sc7180: Add pazquel dts files

From: Doug Anderson
Date: Mon Jun 27 2022 - 10:01:04 EST


Hi,

On Sat, Jun 25, 2022 at 6:40 PM Joseph S. Barrera III
<joebar@xxxxxxxxxxxx> wrote:
>
> Pazquel is a trogdor-based board. These dts files are unchanged copies
> from the downstream Chrome OS 5.4 kernel.
>
> Signed-off-by: Joseph S. Barrera III <joebar@xxxxxxxxxxxx>
> ---
>
> Changes in v14:
> - Remove unidiomatic compile-time test for duplicate include.
>
> Changes in v13:
> - Remove 'include sc7180-trogdor.dtsi' in sc7180-trogdor-ti-sn65dsi86.dtsi.
> - Add compile-time test for duplicate include in sc7180-trogdor.dtsi.
>
> Changes in v12:
> - Replace 'include sc7180.dtsi' with 'include sc7180-trogdor.dtsi'
> in sc7180-trogdor-ti-sn65dsi86.dtsi.
>
> Changes in v11:
> - Add 'include sc7180-trogdor.dtsi' to sc7180-trogdor-pazquel-* files.
> - Restore 'include sc7180.dtsi' to sc7180-trogdor-ti-sn65dsi86.dtsi.
>
> Changes in v10:
> - Remove 'include sc7180.dtsi' from *all* sc7180-trogdor-pazquel* files.
> - Move "okay" for ap_tp_i2c to proper location.
>
> Changes in v9:
> - Restore two lines accidentally removed from ap_sar_sensor.
> - Simplify trackpad enabling (51d30402be75).
>
> Changes in v7:
> - Only include sc7180.dtsi in sc7180-trogdor.dtsi (19794489fa24).
> - Simplify spi0/spi6 labeling (d277cab7afc7).
> - Remove #include of <arm/cros-ec-keyboard.dtsi>.
> - Accidentally removed two lines from ap_sar_sensor.
>
> Changes in v6:
> - Copy changes to ap_sar_sensor from v5.4.
> - Add #include of <arm/cros-ec-keyboard.dtsi>.
>
> Changes in v4:
> - Fix description (no downstream bits removed).
> - Add missing version history.
>
> Changes in v3:
> - First inclusion in series.
>
> arch/arm64/boot/dts/qcom/Makefile | 4 +
> .../sc7180-trogdor-pazquel-lte-parade.dts | 22 ++
> .../qcom/sc7180-trogdor-pazquel-lte-ti.dts | 22 ++
> .../qcom/sc7180-trogdor-pazquel-parade.dts | 17 ++
> .../dts/qcom/sc7180-trogdor-pazquel-ti.dts | 17 ++
> .../boot/dts/qcom/sc7180-trogdor-pazquel.dtsi | 221 ++++++++++++++++++
> 6 files changed, 303 insertions(+)
> create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts
> create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-ti.dts
> create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-parade.dts
> create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-ti.dts
> create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel.dtsi

Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>

I put this on a google,pazquel-rev3-sku1 and confirmed that it at
least booted up and showed stuff on the screen.

Tested-by: Douglas Anderson <dianders@xxxxxxxxxxxx>