Re: [PATCH v1 2/2] mfd: intel_soc_pmic_chtwc: Switch from __maybe_unused to pm_sleep_ptr() etc

From: Andy Shevchenko
Date: Mon Jun 20 2022 - 05:40:44 EST


On Mon, Jun 20, 2022 at 10:48:01AM +0200, Hans de Goede wrote:
> On 6/16/22 19:10, Andy Shevchenko wrote:
> > Letting the compiler remove these functions when the kernel is built
> > without CONFIG_PM_SLEEP support is simpler and less heavier for builds
> > than the use of __maybe_unused attributes.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>
> I see that this basically converts the code to the new way of dealing
> with pm_ops, so after a second look:
>
> Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx>

Thanks!

--
With Best Regards,
Andy Shevchenko