Re: [PATCH 2/2] tty: serial: qcom-geni-serial: Implement start_rx callback

From: Doug Anderson
Date: Wed Jun 08 2022 - 11:39:58 EST


Hi,

On Tue, Jun 7, 2022 at 11:53 AM Vijaya Krishna Nivarthi
<quic_vnivarth@xxxxxxxxxxx> wrote:
>
> In suspend sequence stop_rx will be performed only if implementation for
> start_rx callback is present.
>
> Set qcom_geni_serial_start_rx as callback for start_rx so that stop_rx is
> performed.
>
> Signed-off-by: Vijaya Krishna Nivarthi <quic_vnivarth@xxxxxxxxxxx>
> ---
> drivers/tty/serial/qcom_geni_serial.c | 1 +
> 1 file changed, 1 insertion(+)

I think you also want a Fixes tag here, right? ...because if only the
first patch is taken then it can actually regress Qualcomm devices.
Thus:

Fixes: c9d2325cdb92 ("serial: core: Do stop_rx in suspend path for
console if console_suspend is disabled")

Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>