Re: [PATCH 1/2] serial: core: Introduce callback for start_rx and do stop_rx in suspend only if this callback implementation is present.

[Doug Anderson]

Hi,

On Tue, Jun 7, 2022 at 11:53 AM Vijaya Krishna Nivarthi
<quic_vnivarth@xxxxxxxxxxx> wrote:
>
> In suspend sequence there is a need to perform stop_rx during suspend
> sequence to prevent any asynchronous data over rx line. However this
> can cause problem to drivers which dont do re-start_rx during set_termios.
>
> Add new callback start_rx and perform stop_rx only when implementation of
> start_rx is present. Also add call to start_rx in resume sequence so that
> drivers who come across this problem can make use of this framework.
>
> Fixes: c9d2325cdb92 ("serial: core: Do stop_rx in suspend path for console if console_suspend is disabled")
> Signed-off-by: Vijaya Krishna Nivarthi <quic_vnivarth@xxxxxxxxxxx>
> ---
>  drivers/tty/serial/serial_core.c | 9 ++++++---
>  include/linux/serial_core.h      | 1 +
>  2 files changed, 7 insertions(+), 3 deletions(-)

Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>