On Fri, Feb 11, 2022 at 04:34:41PM -0600, Smita Koralahalli wrote:Hmm okay. The main thought to come up with this patch was of course speed.
Cache the value of MCA_CONFIG[McaX] in the existing mce_bank structI don't see the point for this change, frankly.
similar to MCA_CONFIG[McaLsbInStatusSupported].
This simplifies and eliminates the need to read MCA_CONFIG register each
time to check McaX.
I doubt it is speed because those are not really hot paths.
Code savings ain't either: 5 files changed, 36 insertions(+), 22 deletions(-)
Having yet another exported function to modules if not really necessary
doesn't make it prettier too.
So if there's no point for it, you can simply drop it.
Thx.