Re: [PATCH v3 3/4] x86/mce, EDAC/mce_amd: Cache MCA_CONFIG[McaX] in struct mce_bank
From: Borislav Petkov
Date: Tue Feb 22 2022 - 10:36:25 EST
On Fri, Feb 11, 2022 at 04:34:41PM -0600, Smita Koralahalli wrote:
> Cache the value of MCA_CONFIG[McaX] in the existing mce_bank struct
> similar to MCA_CONFIG[McaLsbInStatusSupported].
>
> This simplifies and eliminates the need to read MCA_CONFIG register each
> time to check McaX.
I don't see the point for this change, frankly.
I doubt it is speed because those are not really hot paths.
Code savings ain't either: 5 files changed, 36 insertions(+), 22 deletions(-)
Having yet another exported function to modules if not really necessary
doesn't make it prettier too.
So if there's no point for it, you can simply drop it.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette