Re: [PATCH 5/5] pinctrl: mediatek: common-v1: Commonize spec_ies_smt_set callback

[AngeloGioacchino Del Regno]

Il 21/02/22 10:58, Chen-Yu Tsai ha scritto:
> On Thu, Feb 10, 2022 at 10:21 PM AngeloGioacchino Del Regno
> <angelogioacchino.delregno@xxxxxxxxxxxxx> wrote:
> > All of the MediaTek pinctrl drivers registering with pinctrl-mtk-common
> > that are offering a .spec_ies_smt_set() callback are declaring their
> > own function which is doing exactly the same on all drivers: calling
> > mtk_pconf_spec_set_ies_smt_range() with their struct and a simple check.
> >
> > Commonize this callback by adding the ies and smt structure pointers
> > to struct mtk_pinctrl_devdata and changing the callback signature to
> > take it.
> >
> > Removing the callback and checking for the existence of the spec_smt
> > and/or spec_ies data would allow us to staticize the function
> > mtk_pconf_spec_set_ies_smt_range(), but this solution was avoided as
> > to keep flexibility, as some SoCs may need to perform a very different
> > operation compared to what this commonized function is doing.
> >
> > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
>
> Signed-off-by: Chen-Yu Tsai <wenst@xxxxxxxxxxxx>

Hi Chen-Yu,

did you mean Reviewed-by? :-)