Re: [PATCH v2] KVM: SEV: Allow SEV intra-host migration of VM with mirrors

[Peter Gonda]

On Mon, Feb 14, 2022 at 5:57 AM Paolo Bonzini <pbonzini@xxxxxxxxxx> wrote:
>
> On 2/11/22 20:36, Peter Gonda wrote:
> > +     list_cut_before(&dst->mirror_vms, &src->mirror_vms, &src->mirror_vms);
> > +     list_for_each_entry_safe(mirror, tmp, &dst->mirror_vms,
> > +                              mirror_entry) {
>
> Is list_for_each_entry_safe actually necessary here?  (It would be if
> you used list_add/list_del instead of list_cut_before).

 I don't think so, I think we could use list_for_each_entry here. Do
you want me to send another revision?

>
> > +             kvm_get_kvm(dst_kvm);
> > +             kvm_put_kvm(src_kvm);
> > +             mirror->enc_context_owner = dst_kvm;
> > +     }
>
> Thanks,
>
> Paolo
>