Re: [PATCH v2] KVM: SEV: Allow SEV intra-host migration of VM with mirrors

From: Paolo Bonzini
Date: Mon Feb 14 2022 - 07:57:45 EST


On 2/11/22 20:36, Peter Gonda wrote:
+ list_cut_before(&dst->mirror_vms, &src->mirror_vms, &src->mirror_vms);
+ list_for_each_entry_safe(mirror, tmp, &dst->mirror_vms,
+ mirror_entry) {

Is list_for_each_entry_safe actually necessary here? (It would be if you used list_add/list_del instead of list_cut_before).

+ kvm_get_kvm(dst_kvm);
+ kvm_put_kvm(src_kvm);
+ mirror->enc_context_owner = dst_kvm;
+ }

Thanks,

Paolo