RE: [PATCH 01/10] ARM: dts: exynos: add missing HDMI supplies on SMDK5250

From: Alim Akhtar
Date: Wed Feb 09 2022 - 22:03:39 EST




>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@xxxxxxxxxxxxx]
>Sent: Tuesday, February 8, 2022 10:48 PM
>To: Inki Dae <inki.dae@xxxxxxxxxxx>; Joonyoung Shim
><jy0922.shim@xxxxxxxxxxx>; Seung-Woo Kim
><sw0312.kim@xxxxxxxxxxx>; Kyungmin Park
><kyungmin.park@xxxxxxxxxxx>; David Airlie <airlied@xxxxxxxx>; Daniel
>Vetter <daniel@xxxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>; Krzysztof
>Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>; Alim Akhtar
><alim.akhtar@xxxxxxxxxxx>; Kishon Vijay Abraham I <kishon@xxxxxx>;
>Vinod Koul <vkoul@xxxxxxxxxx>; dri-devel@xxxxxxxxxxxxxxxxxxxxx;
>devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-
>samsung-soc@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-
>phy@xxxxxxxxxxxxxxxxxxx
>Cc: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>; Sylwester Nawrocki
><snawrocki@xxxxxxxxxx>; stable@xxxxxxxxxxxxxxx
>Subject: [PATCH 01/10] ARM: dts: exynos: add missing HDMI supplies on
>SMDK5250
>
>Add required VDD supplies to HDMI block on SMDK5250. Without them, the
>HDMI driver won't probe. Because of lack of schematics, use same supplies
as
>on Arndale 5250 board (voltage matches).
>
>Cc: <stable@xxxxxxxxxxxxxxx> # v3.15+
>Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>
>---
> arch/arm/boot/dts/exynos5250-smdk5250.dts | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts
>b/arch/arm/boot/dts/exynos5250-smdk5250.dts
>index 65d2474f83eb..21fbbf3d8684 100644
>--- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
>+++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
>@@ -118,6 +118,9 @@ &hdmi {
> status = "okay";
> ddc = <&i2c_2>;
> hpd-gpios = <&gpx3 7 GPIO_ACTIVE_HIGH>;
>+ vdd-supply = <&ldo8_reg>;
>+ vdd_osc-supply = <&ldo10_reg>;
>+ vdd_pll-supply = <&ldo8_reg>;
> };

Cross checked with SMDK schematic, looks correct.

Reviewed-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>

>
> &i2c_0 {
>--
>2.32.0