Re: [RFC PATCH 3/5] firmware_loader: Split fw_sysfs support from fallback

[Luis Chamberlain]

On Thu, Feb 03, 2022 at 02:30:50PM -0700, Russ Weight wrote:
> In preparation for sharing the "loading" and "data" sysfs nodes with the
> new firmware upload support, split out sysfs functionality from fallback.c
> and fallback.h into fw_sysfs.c and fw_sysfs.h. This includes the firmware
> class driver code that is associated with the sysfs files and the
> fw_fallback_config support for the timeout sysfs node.
> 
> CONFIG_FW_LOADER_SYSFS is created and is selected by
> CONFIG_FW_LOADER_USER_HELPER in order to include fw_sysfs.o in
> firmware_class-objs.
> 
> This is mostly just a code reorganization. There are a few symbols that
> change in scope, and these can be identified by looking at the header
> file changes. A few white-space warnings from checkpatch are also
> addressed in this patch.
> 
> Signed-off-by: Russ Weight <russell.h.weight@xxxxxxxxx>
> ---
>  drivers/base/firmware_loader/Kconfig    |   4 +
>  drivers/base/firmware_loader/Makefile   |   1 +
>  drivers/base/firmware_loader/fallback.c | 430 ------------------------
>  drivers/base/firmware_loader/fallback.h |  46 +--
>  drivers/base/firmware_loader/fw_sysfs.c | 413 +++++++++++++++++++++++
>  drivers/base/firmware_loader/fw_sysfs.h |  94 ++++++

Nit: please just use sysfs.[ch]. The directory already implies its for
firmware.

  Luis