Re: Aligning tcmalloc with glibc 2.35 rseq ABI

From: Carlos O'Donell
Date: Wed Feb 02 2022 - 12:32:01 EST


On 2/2/22 10:01, Florian Weimer via Libc-alpha wrote:
> * Mathieu Desnoyers:
>
>> More to the point: is ptrdiff_t the correct type here ? I think so.
>> Do we want to revert the ABI and wait another 6 months before we
>> bring back rseq into glibc just for this ? I'm not sure this limitation
>> justifies it.
>>
>> So if there is a quick way to fix that before the official 2.35 release,
>> I'm all for it, otherwise I cannot say that __rseq_offset being an "int"
>> rather than a "ptrdiff_t" will make much real-life difference (unless
>> I'm proven wrong). But we will be stuck with this quirk forever.
>
> I'm going to post a patch. It's fairly small.

I'll review this as glibc release manager for glibc 2.35.

We'll get this right before I cut the release.

--
Cheers,
Carlos.