Re: [PATCH v5 7/8] KVM: VMX: Update PID-pointer table entry when APIC ID is changed

From: Tom Lendacky
Date: Thu Jan 06 2022 - 09:06:24 EST


On 1/5/22 7:44 PM, Zeng Guang wrote:
On 1/6/2022 3:13 AM, Tom Lendacky wrote:
On 12/31/21 8:28 AM, Zeng Guang wrote:

Won't this blow up on AMD since there is no corresponding SVM op?

Thanks,
Tom
Right, need check ops validness to avoid ruining AMD system. Same consideration on ops "update_ipiv_pid_table" in patch8.

Not necessarily for patch8. That is "protected" by the kvm_check_request(KVM_REQ_PID_TABLE_UPDATE, vcpu) test, but it couldn't hurt.

Thanks,
Tom

I will revise in next version. Thanks.
+        } else
               ret = 1;
           break;