Re: [PATCH v3 1/3] ALSA: hda/tegra: Fix Tegra194 HDA reset failure

From: Sameer Pujar
Date: Thu Dec 23 2021 - 06:24:27 EST




On 12/23/2021 12:46 PM, Greg KH wrote:
On Thu, Dec 23, 2021 at 10:04:19AM +0530, Sameer Pujar wrote:

On 12/23/2021 12:10 AM, Dmitry Osipenko wrote:
22.12.2021 07:35, Sameer Pujar пишет:
HDA regression is recently reported on Tegra194 based platforms.
This happens because "hda2codec_2x" reset does not really exist
in Tegra194 and it causes probe failure. All the HDA based audio
tests fail at the moment. This underlying issue is exposed by
commit c045ceb5a145 ("reset: tegra-bpmp: Handle errors in BPMP
response") which now checks return code of BPMP command response.
Fix this issue by skipping unavailable reset on Tegra194.

Signed-off-by: Sameer Pujar <spujar@xxxxxxxxxx>
Cc: stable@xxxxxxxxxxxxxxx
Depends-on: 87f0e46e7559 ("ALSA: hda/tegra: Reset hardware")
Is "Depends-on" a valid tag? I can't find it in Documentation/.
I do find the usage of the tag in many commits though there is no reference
of this in doc. I always thought it would act as a reference when commits
get pulled to other branches. If this is not true and it does not mean
anything, I will drop this.
It is not true at all, please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

Thanks Greg for the pointer. I will drop above tag in v4.