Re: [PATCH] hwmon : (mr75203) fix macro typo

From: Andy Shevchenko
Date: Fri Dec 17 2021 - 11:46:47 EST


On Fri, Dec 17, 2021 at 08:05:17AM -0800, Guenter Roeck wrote:
> On 12/16/21 6:19 AM, Andy Shevchenko wrote:
> > On Thu, Dec 16, 2021 at 11:33:02AM +0300, Arseny Demidov wrote:

...

> > > -#define POWER_DELAY_CYCLE_256 0x80
> > > +#define POWER_DELAY_CYCLE_256 0x100
> > > #define POWER_DELAY_CYCLE_64 0x40
> >
> > I;m wondering why they are in hex? Perhaps the decimal is better for both.
> >
> Maybe, but that is POV, and I tend to leave it up to driver authors to decide.
> It is definitely not something we would want to change as part of a bug fix.

Agreed on both points.

--
With Best Regards,
Andy Shevchenko