Re: [PATCH] hwmon : (mr75203) fix macro typo

[Guenter Roeck]

On 12/16/21 6:19 AM, Andy Shevchenko wrote:
> On Thu, Dec 16, 2021 at 11:33:02AM +0300, Arseny Demidov wrote:
> > In the file mr75203.c we have a macro named POWER_DELAY_CYCLE_256,
> > the correct value should be 0x100. The register ip_tmr is expressed
> > in units of IP clk cycles, in accordance with the datasheet.
> > Typical power-up delays for Temperature Sensor are 256 cycles i.e. 0x100.
>
> Should you provide Fixes tag?

Yes. Also, please update the subject. This is not about "fix macro typo".
it fixes a wrong/bad delay value.

> ...
>
> > -#define POWER_DELAY_CYCLE_256	0x80
> > +#define POWER_DELAY_CYCLE_256	0x100
> >   #define POWER_DELAY_CYCLE_64	0x40
>
> I;m wondering why they are in hex? Perhaps the decimal is better for both.
Maybe, but that is POV, and I tend to leave it up to driver authors to decide.
It is definitely not something we would want to change as part of a bug fix.

Thanks,
Guenter