Re: [PATCH 2/4] x86/mm: make kernel_physical_mapping_change() __init

From: Edgecombe, Rick P
Date: Thu Nov 11 2021 - 15:47:32 EST


On Thu, 2021-11-11 at 13:02 +0200, Mike Rapoport wrote:
> From: Mike Rapoport <rppt@xxxxxxxxxxxxx>
>
> kernel_physical_mapping_change() is __meminit although it is only
> called by
> __init function early_set_memory_enc_dec().
>
> Make kernel_physical_mapping_change() __init.
>
> Signed-off-by: Mike Rapoport <rppt@xxxxxxxxxxxxx>

Reviewed-by: Rick Edgecombe <rick.p.edgecombe@xxxxxxxxx>

> ---
> arch/x86/mm/init_64.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
> index 36098226a957..9a24532d2b85 100644
> --- a/arch/x86/mm/init_64.c
> +++ b/arch/x86/mm/init_64.c
> @@ -794,7 +794,7 @@ kernel_physical_mapping_init(unsigned long
> paddr_start,
> * when updating the mapping. The caller is responsible to flush the
> TLBs after
> * the function returns.
> */
> -unsigned long __meminit
> +unsigned long __init
> kernel_physical_mapping_change(unsigned long paddr_start,
> unsigned long paddr_end,
> unsigned long page_size_mask)