Re: [PATCH 1/4] x86/mm: make init_trampoline_kaslr() __init

From: Edgecombe, Rick P
Date: Thu Nov 11 2021 - 15:46:43 EST


On Thu, 2021-11-11 at 13:02 +0200, Mike Rapoport wrote:
> From: Mike Rapoport <rppt@xxxxxxxxxxxxx>
>
> init_trampoline_kaslr() is __meminit although it is only called by
> __init
> function init_trampoline().
>
> Make init_trampoline_kaslr() __init.
>
> Signed-off-by: Mike Rapoport <rppt@xxxxxxxxxxxxx>

Reviewed-by: Rick Edgecombe <rick.p.edgecombe@xxxxxxxxx>

> ---
> arch/x86/mm/kaslr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/mm/kaslr.c b/arch/x86/mm/kaslr.c
> index 557f0fe25dff..d40bb4feeda3 100644
> --- a/arch/x86/mm/kaslr.c
> +++ b/arch/x86/mm/kaslr.c
> @@ -138,7 +138,7 @@ void __init kernel_randomize_memory(void)
> }
> }
>
> -void __meminit init_trampoline_kaslr(void)
> +void __init init_trampoline_kaslr(void)
> {
> pud_t *pud_page_tramp, *pud, *pud_tramp;
> p4d_t *p4d_page_tramp, *p4d, *p4d_tramp;