Re: [PATCH] dmaengine: tegra210-adma: fix pm runtime unbalance in tegra_adma_remove

[Jon Hunter]

On 21/10/2021 04:14, Dongliang Mu wrote:
> Since pm_runtime_put is done when tegra_adma_probe is successful, we
> cannot do pm_runtime_put_sync again in tegra_adma_remove.
>
> Fix this by removing the pm_runtime_put_sync in tegra_adma_remove.
>
> Signed-off-by: Dongliang Mu <mudongliangabcd@xxxxxxxxx>
> ---
>   drivers/dma/tegra210-adma.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/dma/tegra210-adma.c b/drivers/dma/tegra210-adma.c
> index b1115a6d1935..7e4d40cd9577 100644
> --- a/drivers/dma/tegra210-adma.c
> +++ b/drivers/dma/tegra210-adma.c
> @@ -940,7 +940,6 @@ static int tegra_adma_remove(struct platform_device *pdev)
>   	for (i = 0; i < tdma->nr_channels; ++i)
>   		irq_dispose_mapping(tdma->channels[i].irq);
>   
> -	pm_runtime_put_sync(&pdev->dev);
>   	pm_runtime_disable(&pdev->dev);
>   
>   	return 0;

Thanks!

Reviewed-by: Jon Hunter <jonathanh@xxxxxxxxxx>

Jon

--
nvpublic