Re: [PATCH] dmaengine: tegra210-adma: fix pm runtime unbalance

[Jon Hunter]

On 21/10/2021 04:05, Dongliang Mu wrote:
> The previous commit 059e969c2a7d ("dmaengine: tegra210-adma: Using
> pm_runtime_resume_and_get to replace open coding") forgets to replace
> the pm_runtime_get_sync in the tegra_adma_probe, but removes the
> pm_runtime_put_noidle.
>
> Fix this by continuing to replace pm_runtime_get_sync with
> pm_runtime_resume_and_get in tegra_adma_probe.
>
> Fixes: 059e969c2a7d ("dmaengine: tegra210-adma: Using pm_runtime_resume_and_get to replace open coding")
> Signed-off-by: Dongliang Mu <mudongliangabcd@xxxxxxxxx>
> ---
>   drivers/dma/tegra210-adma.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/tegra210-adma.c b/drivers/dma/tegra210-adma.c
> index b1115a6d1935..d1dff3a29db5 100644
> --- a/drivers/dma/tegra210-adma.c
> +++ b/drivers/dma/tegra210-adma.c
> @@ -867,7 +867,7 @@ static int tegra_adma_probe(struct platform_device *pdev)
>   
>   	pm_runtime_enable(&pdev->dev);
>   
> -	ret = pm_runtime_get_sync(&pdev->dev);
> +	ret = pm_runtime_resume_and_get(&pdev->dev);
>   	if (ret < 0)
>   		goto rpm_disable;
>   

Thanks!

Reviewed-by: Jon Hunter <jonathanh@xxxxxxxxxx>

Jon

--
nvpublic