Re: [PATCH] hyperv: root partition faults writing to VP ASSIST MSR PAGE

[Wei Liu]

On Tue, Jul 20, 2021 at 06:55:56PM +0530, Praveen Kumar wrote:
[...]
> > 
> >> +	if (hv_root_partition &&
> >> +	    ms_hyperv.features & HV_MSR_APIC_ACCESS_AVAILABLE) {
> > 
> > Is HV_MSR_APIC_ACCESS_AVAILABLE a root only flag? Shouldn't non-root
> > kernel check this too?
> 
> Yes, you are right. Will update this in v2. thanks.

Please split adding this check to its own patch.

Ideally one patch only does one thing.

Wei.

> 
> > 
> > Wei.
> > 
> 
> Regards,
> 
> ~Praveen.