Re: [PATCH v2] dt-bindings: opp: Convert to DT schema

From: Rob Herring
Date: Tue Jul 20 2021 - 09:38:43 EST


On Tue, Jul 20, 2021 at 10:01:08AM +0530, Viresh Kumar wrote:
> On 19-07-21, 14:27, Rob Herring wrote:
> > Convert the OPP v1 and v2 bindings to DT schema format. As the OPPv2 binding
> > can be extended by vendors, we need to split the common part out from the
> > "operating-points-v2" conforming compatible.
> >
> > Cc: Yangtao Li <tiny.windzz@xxxxxxxxx>
> > Cc: Nishanth Menon <nm@xxxxxx>
> > Cc: Stephen Boyd <sboyd@xxxxxxxxxx>
> > Cc: Maxime Ripard <mripard@xxxxxxxxxx>
> > Cc: Chen-Yu Tsai <wens@xxxxxxxx>
> > Cc: linux-pm@xxxxxxxxxxxxxxx
> > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> > Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
> > Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
> > ---
> > v2:
> > - move opp-peak-kBps next to opp-avg-kBps. Also add a dependency schema.
> > - Correct the opp-microamp schemas. It's always a single value for each
> > regulator.
> > - Add missing type for '^opp-microamp-'
>
> Applied. Thanks.

I found some issues with it, can you drop it?

Rob