Re: [PATCH] ELF: add and use SUPRESS_WARN_UNUSED_RESULT

From: Randy Dunlap
Date: Fri Jun 25 2021 - 17:11:43 EST


On 6/25/21 2:10 PM, Alexey Dobriyan wrote:
> On Fri, Jun 25, 2021 at 10:34:29PM +0200, Miguel Ojeda wrote:
>> On Fri, Jun 25, 2021 at 9:52 PM Alexey Dobriyan <adobriyan@xxxxxxxxx> wrote:
>>>
>>> +/*
>>> + * "(void)" is enough for clang but not for gcc.
>>> + */
>>> +#define SUPRESS_WARN_UNUSED_RESULT (void)!
>>
>> While it is related to the attribute, this macro is not an attribute,
>> so please add it somewhere else.
>
> This is natural place. If you're supressing WUR, then the WUR macro
> itself is defined implying that the header has been included.
>
>> By the way, the name has a typo.
>
> Ha!
>

as in Aha!?

s/SUPRESS/SUPPRESS/