Re: [PATCH net-next 5/8] net: hdlc_ppp: fix the comments style issue

[lipeng (Y)]

在 2021/6/17 0:20, Andrew Lunn 写道:
> >   static int cp_table[EVENTS][STATES] = {
> >   	/* CLOSED     STOPPED STOPPING REQ_SENT ACK_RECV ACK_SENT OPENED
> > -	     0           1         2       3       4      5          6    */
> > +	 *   0           1         2       3       4      5          6
> > +	 */
> >   	{IRC|SCR|3,     INV     , INV ,   INV   , INV ,  INV    ,   INV   }, /* START */
> >   	{   INV   ,      0      ,  0  ,    0    ,  0  ,   0     ,    0    }, /* STOP */
> >   	{   INV   ,     INV     ,STR|2,  SCR|3  ,SCR|3,  SCR|5  ,   INV   }, /* TO+ */
> This probably reduces the readability of the code. So i would not make
> this change.
>
> Please remember these are only guidelines. Please don't blindly make
> changes, or change it because some bot says so. Check that it actually
> makes sense and the code is better afterwards.
>
>        Andrew
> .

Agree with you they are only guidelines.

The code should  follow the rules mostly, or  it will be diferent style 
from different developer.

If that's the exception, i will drop this patch.


Thanks

            Peng Li