Re: [PATCH net-next 5/8] net: hdlc_ppp: fix the comments style issue

From: Andrew Lunn
Date: Wed Jun 16 2021 - 12:20:20 EST


> static int cp_table[EVENTS][STATES] = {
> /* CLOSED STOPPED STOPPING REQ_SENT ACK_RECV ACK_SENT OPENED
> - 0 1 2 3 4 5 6 */
> + * 0 1 2 3 4 5 6
> + */
> {IRC|SCR|3, INV , INV , INV , INV , INV , INV }, /* START */
> { INV , 0 , 0 , 0 , 0 , 0 , 0 }, /* STOP */
> { INV , INV ,STR|2, SCR|3 ,SCR|3, SCR|5 , INV }, /* TO+ */

This probably reduces the readability of the code. So i would not make
this change.

Please remember these are only guidelines. Please don't blindly make
changes, or change it because some bot says so. Check that it actually
makes sense and the code is better afterwards.

Andrew