Re: [PATCH] net: appletalk: fix some mistakes in grammar

From: Seth David Schoen
Date: Mon Jun 07 2021 - 22:50:44 EST


13145886936@xxxxxxx writes:

> * Ergo, before the AppleTalk module can be removed, all AppleTalk
> - * sockets be closed from user space.
> + * sockets should be closed from user space.
> */

This is a good correction, but in the other case

> /*
> * Phase 1 is fine on LocalTalk but we don't do
> - * EtherTalk phase 1. Anyone wanting to add it go ahead.
> + * EtherTalk phase 1. Anyone wanting to add it goes ahead.

"go ahead" is meant as an imperative (like "If you want to add EtherTalk
phase 1 support, please go ahead [and do so]"), not an indicative (like
"If you want to add EtherTalk phase 1 support, you are adding it"). It
is an invitation addressed to future developers.

Addressing unspecified people directly in the second person with "anyone"
is a little unusual, but is grammatically acceptable (more usually with a
comma). Anyone reading this, you now understand this point.