Re: [PATCH] net: appletalk: fix some mistakes in grammar

From: Randy Dunlap
Date: Mon Jun 07 2021 - 22:36:29 EST


On 6/7/21 7:25 PM, 13145886936@xxxxxxx wrote:
> From: gushengxian <gushengxian@xxxxxxxxxx>
>
> Fix some mistakes in grammar.
>
> Signed-off-by: gushengxian <gushengxian@xxxxxxxxxx>
> ---
> net/appletalk/ddp.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/net/appletalk/ddp.c b/net/appletalk/ddp.c
> index ebda397fa95a..bc76b2fa3dfb 100644
> --- a/net/appletalk/ddp.c
> +++ b/net/appletalk/ddp.c
> @@ -707,7 +707,7 @@ static int atif_ioctl(int cmd, void __user *arg)
>
> /*
> * Phase 1 is fine on LocalTalk but we don't do
> - * EtherTalk phase 1. Anyone wanting to add it go ahead.
> + * EtherTalk phase 1. Anyone wanting to add it goes ahead.
> */
> if (dev->type == ARPHRD_ETHER && nr->nr_phase != 2)
> return -EPROTONOSUPPORT;
> @@ -828,7 +828,7 @@ static int atif_ioctl(int cmd, void __user *arg)
> nr = (struct atalk_netrange *)&(atif->nets);
> /*
> * Phase 1 is fine on Localtalk but we don't do
> - * Ethertalk phase 1. Anyone wanting to add it go ahead.
> + * Ethertalk phase 1. Anyone wanting to add it goes ahead.

Nak on these 2 changes.
If anything, it could be something like:
Anyone wanting to add it, go ahead.
or
If anyone wants to add it, go ahead.


> */
> if (dev->type == ARPHRD_ETHER && nr->nr_phase != 2)
> return -EPROTONOSUPPORT;
> @@ -2018,7 +2018,7 @@ module_init(atalk_init);
> * by the network device layer.
> *
> * Ergo, before the AppleTalk module can be removed, all AppleTalk
> - * sockets be closed from user space.
> + * sockets should be closed from user space.

ok.

> */
> static void __exit atalk_exit(void)
> {
>


--
~Randy