Re: [PATCH -next] x86/kprobes: functions should not be declared extern

[Qiheng Lin]

在 2021/5/31 18:39, Borislav Petkov 写道:
> > Subject: Re: [PATCH -next] x86/kprobes: functions should not be declared extern
>
> The condensed patch description in the subject line should start with a
> uppercase letter and should be written in imperative tone.
>
> Also, the subject is wrong. Hint: "declaration" vs "definition".
>
> On Mon, May 31, 2021 at 11:10:09AM +0800, Qiheng Lin wrote:
> > The function declaration in kprobes.h is already marked extern, thus its
> > definition should not have the keyword.
> >
> > This quiets the following sparse warning:
> >   function 'arch_unoptimize_kprobes' with external linkage has definition
>
> This sounds like you're fixing something just because some tool
> complains and not because there's a real problem you're fixing.
>
> Please rewrite your commit messages to state what the problem is and
> why you're fixing that problem. The tool output can be used to say
> something along the lines of "this problem was caught by this tool" but
> not as "see, tool X complains and creates a warning and I must fix that
> warning immediately."

Thank you for the review. I will send the v2.