Re: [PATCH v5 2/5] media: dt-bindings: media: renesas,drif: Convert to json-schema

[Rob Herring]

On Thu, Jan 14, 2021 at 7:02 AM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
>
> Hi Fabrizio, Rob,
>
> On Wed, Oct 21, 2020 at 3:53 PM Fabrizio Castro
> <fabrizio.castro.jz@xxxxxxxxxxx> wrote:
> > Convert the Renesas DRIF bindings to DT schema and update
> > MAINTAINERS accordingly.
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@xxxxxxxxxxx>
> > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> > Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
>
> Thanks for your patch!
>
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/renesas,drif.yaml
>
> > +  clock-names:
> > +    maxItems: 1
> > +    items:
> > +      - const: fck
>
> With latest dt-schema, "make dt_binding_check" complains:
>
>     Documentation/devicetree/bindings/media/renesas,drif.yaml:
> properties:clock-names:maxItems: False schema does not allow 1
>     Documentation/devicetree/bindings/media/renesas,drif.yaml:
> ignoring, error in schema: properties: clock-names: maxItems

Seems this just got applied, and now this error is in linux-next.

>
> Using
>
>        clock-names:
>          const: fck
>
> Fixes that.
>
> However, I'm wondering why I do not get a complaint about the similar
> clock/clock-names in
> Documentation/devicetree/bindings/display/bridge/renesas,lvds.yaml.
> Because they're part of an else branch?

Probably. if/then/else schemas have fewer checks as they can be
incomplete (only additional constraints on the top-level schema).

Rob