Re: [PATCH] net/rds: Avoid potential use after free in rds_send_remove_from_sock

From: Santosh Shilimkar
Date: Wed Apr 07 2021 - 14:27:08 EST



> On Apr 6, 2021, at 5:09 PM, Aditya Pakki <pakki001@xxxxxxx> wrote:
>
> In case of rs failure in rds_send_remove_from_sock(), the 'rm' resource
> is freed and later under spinlock, causing potential use-after-free.
> Set the free pointer to NULL to avoid undefined behavior.
>
> Signed-off-by: Aditya Pakki <pakki001@xxxxxxx>
> ---
> net/rds/message.c | 1 +
> net/rds/send.c | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)

Looks fine by me. Thanks.

Acked-by: Santosh Shilimkar <santosh.shilimkar@xxxxxxxxxx>