Re: [PATCH 2/2] x86/sgx: Add sgx_nr_{all, free}_pages to the debugfs

[Jarkko Sakkinen]

On Thu, Apr 01, 2021 at 12:32:58PM -0700, Dave Hansen wrote:
> On 3/31/21 10:21 PM, Jarkko Sakkinen wrote:
> > +#ifdef CONFIG_DEBUG_FS
> > +	debugfs_create_file("sgx_nr_all_pages", 0400, arch_debugfs_dir, NULL,
> > +			    &sgx_nr_all_pages_fops);
> > +	debugfs_create_file("sgx_nr_free_pages", 0400, arch_debugfs_dir, NULL,
> > +			    &sgx_nr_free_pages_fops);
> > +#endif /* CONFIG_DEBUG_FS */
> 
> 
> Why not make the types u64's and use debugfs_create_u64()?  That would
> save a ton of code.  There's also debugfs_create_ulong().

Because I was not aware of that. For sure can be used.

/Jarkko