Re: [PATCH 2/2] x86/sgx: Add sgx_nr_{all, free}_pages to the debugfs
From: Dave Hansen
Date: Thu Apr 01 2021 - 15:33:04 EST
On 3/31/21 10:21 PM, Jarkko Sakkinen wrote:
> +#ifdef CONFIG_DEBUG_FS
> + debugfs_create_file("sgx_nr_all_pages", 0400, arch_debugfs_dir, NULL,
> + &sgx_nr_all_pages_fops);
> + debugfs_create_file("sgx_nr_free_pages", 0400, arch_debugfs_dir, NULL,
> + &sgx_nr_free_pages_fops);
> +#endif /* CONFIG_DEBUG_FS */
Why not make the types u64's and use debugfs_create_u64()? That would
save a ton of code. There's also debugfs_create_ulong().