Re: [PATCH v1 0/2] Add imx8m power domain driver

From: Abel Vesa
Date: Fri Apr 02 2021 - 13:42:57 EST


On 21-04-02 18:45:04, Adrien Grassein wrote:
> Hi,
>
> this patch et aims to add the support of the i.MX 8 Power Domain driver.
> Some devices (like usbotg2) can't work without this patch as their
> attached power domain are down.
>
> The original drivr was taken from le imx kernel and aapted to fit with
> the actual mainline (minor fixes).
>
> Thanks,
>

Big NACK for the whole series.

This approach has already been rejected upstream.

Plus, you changed the original author, this work was originally done by Jacky Bai.

> Adrien Grassein (2):
> dt-bindings: power: Add documentation for imx8m power domain driver
> soc: imx: add Power Domain driver for i.MX8M(M|N|P)
>
> .../bindings/power/fsl,imx-power-domain.yaml | 89 +++++++
> MAINTAINERS | 10 +
> drivers/soc/imx/Kconfig | 7 +
> drivers/soc/imx/Makefile | 1 +
> drivers/soc/imx/imx8m_pm_domains.c | 233 ++++++++++++++++++
> include/dt-bindings/power/imx8mm-power.h | 21 ++
> include/dt-bindings/power/imx8mn-power.h | 15 ++
> include/dt-bindings/power/imx8mp-power.h | 28 +++
> include/soc/imx/imx_sip.h | 12 +
> 9 files changed, 416 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/power/fsl,imx-power-domain.yaml
> create mode 100644 drivers/soc/imx/imx8m_pm_domains.c
> create mode 100644 include/dt-bindings/power/imx8mm-power.h
> create mode 100644 include/dt-bindings/power/imx8mn-power.h
> create mode 100644 include/dt-bindings/power/imx8mp-power.h
> create mode 100644 include/soc/imx/imx_sip.h
>
> --
> 2.25.1
>