Re: [PATCH v5 15/19] regulator: Support ROHM BD71815 regulators

[Mark Brown]

On Mon, Mar 29, 2021 at 03:59:51PM +0300, Matti Vaittinen wrote:

Acked-by: Mark Brown <broonie@xxxxxxxxxx>

but...

> @@ -0,0 +1,676 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * Copyright 2014 Embest Technology Co. Ltd. Inc.

Please make the entire comment a C++ one so things look more
intentional.

> +#include <linux/regulator/driver.h>
> +#include <linux/regulator/machine.h>

A regulator driver generally shouldn't need machine interfaces...

> +				ret = regulator_enable_regmap(rdev);
> +			else
> +				ret = regulator_disable_regmap(rdev);
> +
> +			if (ret)
> +				dev_err(rdev_get_dev(rdev),
> +					"LED status error\n");

Better to print the error code, and that error message could be a bit
more descriptive.

Attachment: signature.asc
Description: PGP signature