Re: [PATCH v2 0/3] Make fw_devlink=on more forgiving

[Saravana Kannan]

On Tue, Feb 2, 2021 at 1:22 PM Martin Kaiser <martin@xxxxxxxxx> wrote:
>
> Hi Saravana,
>
> Thus wrote Saravana Kannan (saravanak@xxxxxxxxxx):
>
> > Martin,
>
> > If you tested this series, can you please give a Tested-by?
>
> I tested this v2 series on top of next-20210202 (without the fsl,avic
> patch).
>
> If modules are enabled, the kernel doesn't boot on my imx25 board. This
> is expected, I guess.
>
> With modules disabled, the kernel boots but probe fails for some
> (non-mainline) drivers in my tree.

Thanks Martin!

> All of those drivers have a gpio in
> their device-tree node, such as
>
> my_driver {
>    gpio_test1 = <&gpio1 0 0>;
>    ...
> };
>
> with gpio1 from arch/arm/boot/dts/imx25.dtsi.
>
> The probe function calls
>
> of_get_named_gpio(np, "gpio_test1", 0);
>
> to get the gpio. This fails with -EINVAL.

And you didn't see this issue with the fsl,avic patch?

The property you are using is not a standard GPIO binding (-gpios,
gpio, gpios) and I'm not surprised it's not working. The gpio1 is
probably getting probe deferred and ends up running after "my_driver".

-Saravana