Re: [PATCH v2 0/3] Make fw_devlink=on more forgiving

From: Martin Kaiser
Date: Tue Feb 02 2021 - 16:24:37 EST


Hi Saravana,

Thus wrote Saravana Kannan (saravanak@xxxxxxxxxx):

> Martin,

> If you tested this series, can you please give a Tested-by?

I tested this v2 series on top of next-20210202 (without the fsl,avic
patch).

If modules are enabled, the kernel doesn't boot on my imx25 board. This
is expected, I guess.

With modules disabled, the kernel boots but probe fails for some
(non-mainline) drivers in my tree. All of those drivers have a gpio in
their device-tree node, such as

my_driver {
gpio_test1 = <&gpio1 0 0>;
...
};

with gpio1 from arch/arm/boot/dts/imx25.dtsi.

The probe function calls

of_get_named_gpio(np, "gpio_test1", 0);

to get the gpio. This fails with -EINVAL.

Best regards,
Martin