Re: [PATCH v2 3/3] dt-bindings: i2c: qcom,i2c-qup: Document noise rejection properties

[AngeloGioacchino Del Regno]

Il 14/01/21 18:58, Bjorn Andersson ha scritto:
> On Thu 14 Jan 11:49 CST 2021, AngeloGioacchino Del Regno wrote:
>
> > Document the new noise rejection properties "qcom,noise-reject-sda"
> > and "qcom,noise-reject-scl".
>
> I presume these are unit-less levels?
Yes, there is no unit.

Sorry, I've sent v3 before seeing your R-b on this.

> Reviewed-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
>
> Regards,
> Bjorn
>
> > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxxx>
> > ---
> >   .../devicetree/bindings/i2c/qcom,i2c-qup.yaml      | 14 ++++++++++++++
> >   1 file changed, 14 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-qup.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-qup.yaml
> > index c5c7db3ac2a6..3f14dd65c6b9 100644
> > --- a/Documentation/devicetree/bindings/i2c/qcom,i2c-qup.yaml
> > +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-qup.yaml
> > @@ -58,6 +58,20 @@ properties:
> >     '#size-cells':
> >       const: 0
> >   
> > +  qcom,noise-reject-sda:
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +    description: Noise rejection level for the SDA line.
> > +    minimum: 0
> > +    maximum: 3
> > +    default: 0
> > +
> > +  qcom,noise-reject-scl:
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +    description: Noise rejection level for the SCL line.
> > +    minimum: 0
> > +    maximum: 3
> > +    default: 0
> > +
> >   required:
> >     - compatible
> >     - clocks
> > --
> > 2.29.2