Re: [PATCH v2 2/2] ARM: dts: add Protonic MVT board

[Oleksij Rempel]

Hi Shawn,

On Tue, Jan 05, 2021 at 10:35:17AM +0800, Shawn Guo wrote:
> On Tue, Dec 01, 2020 at 08:41:25AM +0100, Oleksij Rempel wrote:
> > PRTMVT is the reference platform for Protonic industrial touchscreen terminals.
> > 
> > Signed-off-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>

> > ---
> > +	gpio-keys {
> > +		compatible = "gpio-keys";
> > +		pinctrl-names = "default";
> > +		pinctrl-0 = <&pinctrl_gpiokeys>;
> > +		autorepeat;
> > +
> > +		power {
> > +			label = "Power Button";
> > +			gpios = <&gpio2 23 GPIO_ACTIVE_LOW>;
> > +			linux,code = <116>; /* KEY_POWER */
> 
> Why not just using defines?

Uff, I didn't noticed there are existing defines. Thx, done.

> > +			wakeup-source;
> > +		};
> > +

> > +	panel {
> > +		compatible = "kyo,tcg070wvlq", "lg,lb070wv8";
> 
> Why do you need two compatibles for a panel?  The first one seems
> undocumented.

kyo,tcg070wvlq seems to be compatible with lg,lb070wv8. Currently there
is no need for driver modification.
The kyo,tcg070wvlq documentation should be added with the patch:
"dt-bindings: display: simple: Add Kyocera tcg070wvlq panel"
https://lkml.org/lkml/2020/12/7/591

> > +		backlight = <&backlight>;
> > +		power-supply = <&reg_3v3>;
> > +	video@5c {
> > +		compatible = "ti,tvp5150";
> > +		reg = <0x5c>;
> > +
> 
> Unnecessary newline.

done

> > +		#address-cells = <1>;
> > +		#size-cells = <0>;
> > +
> > +		port@0 {
> > +			reg = <0>;
> 
> Have a newline between properties and child node.

done

> > +			tvp5150_comp0_in: endpoint {
> > +				remote-endpoint = <&comp0_out>;
> > +			};
> > +		};
> > +
> > +		/* Output port 2 is video output pad */
> > +		port@2 {
> > +			reg = <2>;
> > +			tvp5151_to_ipu1_csi0_mux: endpoint {
> > +				remote-endpoint = <&ipu1_csi0_mux_from_parallel_sensor>;
> > +			};
> > +		};
> > +	};
> > +
> > +	gpio_pca: gpio@74 {
> > +		#gpio-cells = <2>;
> 
> We usually begin with 'compatible'.  Can you move this line after
> 'gpio-controller' maybe?

done

Regards,
Oleksij

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |