Re: [PATCH net 00/17] rxrpc: Prelude to gssapi support

From: Jakub Kicinski
Date: Tue Nov 24 2020 - 15:09:23 EST


On Mon, 23 Nov 2020 20:10:04 +0000 David Howells wrote:
> Here are some patches that do some reorganisation of the security class
> handling in rxrpc to allow implementation of the RxGK security class that
> will allow AF_RXRPC to use GSSAPI-negotiated tokens and better crypto. The
> RxGK security class is not included in this patchset.
>
> It does the following things:
>
> (1) Add a keyrings patch to provide the original key description, as
> provided to add_key(), to the payload preparser so that it can
> interpret the content on that basis. Unfortunately, the rxrpc_s key
> type wasn't written to interpret its payload as anything other than a
> string of bytes comprising a key, but for RxGK, more information is
> required as multiple Kerberos enctypes are supported.
>
> (2) Remove the rxk5 security class key parsing. The rxk5 class never got
> rolled out in OpenAFS and got replaced with rxgk.
>
> (3) Support the creation of rxrpc keys with multiple tokens of different
> types. If some types are not supported, the ENOPKG error is
> suppressed if at least one other token's type is supported.
>
> (4) Punt the handling of server keys (rxrpc_s type) to the appropriate
> security class.
>
> (5) Organise the security bits in the rxrpc_connection struct into a
> union to make it easier to override for other classes.
>
> (6) Move some bits from core code into rxkad that won't be appropriate to
> rxgk.

Pulled into net-next, thank you!