Re: [PATCH 4/5] memory: renesas-rpc-if: Avoid use of C++ style comments

[Sergei Shtylyov]

On 11/24/20 2:25 PM, Lad Prabhakar wrote:

> Replace C++ style comment with C style.

   Thanks, I've overlooked this, and the header files should use C style comment,
not C++.
 
> While at it also replace the tab with a space between struct and
> struct name.

   No connection between these 2 changes, so there should be 2 patches, not 1.
Also, I'd like to ask you that they're left intact (unless it causes problems
for you).

> Suggested-by: Pavel Machek <pavel@xxxxxxx>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
[...]

> diff --git a/include/memory/renesas-rpc-if.h b/include/memory/renesas-rpc-if.h
> index b8c7cc63065f..30ea6bd969b4 100644
> --- a/include/memory/renesas-rpc-if.h
> +++ b/include/memory/renesas-rpc-if.h
> @@ -19,7 +19,7 @@ enum rpcif_data_dir {
>  	RPCIF_DATA_OUT,
>  };
>  
> -struct	rpcif_op {
> +struct rpcif_op {
>  	struct {
>  		u8 buswidth;
>  		u8 opcode;
> @@ -57,7 +57,7 @@ struct	rpcif_op {
>  	} data;
>  };
>  
> -struct	rpcif {
> +struct rpcif {
>  	struct device *dev;
>  	void __iomem *dirmap;
>  	struct regmap *regmap;
> @@ -93,4 +93,4 @@ static inline void rpcif_disable_rpm(struct rpcif *rpc)
>  	pm_runtime_put_sync(rpc->dev);
>  }
>  
> -#endif // __RENESAS_RPC_IF_H
> +#endif /* __RENESAS_RPC_IF_H */

MBR, Sergei