Re: [PATCH net-next v1] net: phy: spi_ks8995: Do not overwrite SPI mode flags

From: Sven Van Asbroeck
Date: Mon Nov 09 2020 - 16:21:00 EST


On Mon, Nov 9, 2020 at 4:09 PM Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
>
> This is a fix right? You seem to be targeting net-next and there is no
> Fixes tag but it sounds like a bug.

I'm not sure. The original code used to work for me, until the spi bus
driver I'm using to communicate to this chip was changed to always
require SPI_CS_HIGH. The current ks8995 driver will now plow over
this flag, and spi communication breaks.

Is this a bug? If so, what should its Fixes commit be? The spi commit
upstream that enables SPI_CS_HIGH on my platform?