Re: [PATCH net-next v1] net: phy: spi_ks8995: Do not overwrite SPI mode flags

From: Jakub Kicinski
Date: Mon Nov 09 2020 - 16:09:03 EST


On Mon, 9 Nov 2020 14:31:17 -0500 Sven Van Asbroeck wrote:
> From: Sven Van Asbroeck <thesven73@xxxxxxxxx>
>
> This driver makes sure the underlying SPI bus is set to "mode 0"
> by assigning SPI_MODE_0 to spi->mode. This overwrites all other
> SPI mode flags.
>
> In some circumstances, this can break the underlying SPI bus driver.
> For example, if SPI_CS_HIGH is set on the SPI bus, the driver
> will clear that flag, which results in a chip-select polarity issue.
>
> Fix by changing only the SPI_MODE_N bits, i.e. SPI_CPHA and SPI_CPOL.
>
> Signed-off-by: Sven Van Asbroeck <thesven73@xxxxxxxxx>

This is a fix right? You seem to be targeting net-next and there is no
Fixes tag but it sounds like a bug.