Re: [GIT PULL] sound updates for 5.9

From: Mark Brown
Date: Mon Aug 10 2020 - 13:51:16 EST


On Mon, Aug 10, 2020 at 06:06:14PM +0100, Srinivas Kandagatla wrote:

> In q6routing case all the dapm widgets reuse reg field in
> snd_soc_dapm_widget to store offset information or routing table indexs or
> some DSP related id and so on... These are not real registers.

> I think the core is trying to read the state of these widgets during
> startup, Which will fail in qdsp6 case as we do not have any regmap or read
> callback associated with this ASoC component.

Yes, it will try to figure out the current state of things during
startup.

> Previously we never had chance to see these messages so we did not implement
> any dummy read callback.

So I guess this is another instance of the issues with other things,
just having an effect beyond the cosmetic this time :/

> Adding a dummy callback to q6routing and q6afe-dai ASoC component will fix
> this issue at-least in Qualcomm case!

Yes, that's going to be better for robustness regardless of changes in
the core - just pick a default state if the underlying thing is
undefined.

Attachment: signature.asc
Description: PGP signature