Re: [PATCH] mm/hmm: remove redundant check non_swap_entry()

From: Ralph Campbell
Date: Fri Jun 12 2020 - 15:48:57 EST



On 6/12/20 12:33 PM, Jason Gunthorpe wrote:
On Fri, Jun 12, 2020 at 12:26:18PM -0700, Ralph Campbell wrote:
In zap_pte_range(), the check for non_swap_entry() and
is_device_private_entry() is redundant since the latter is a subset of the
former. Remove the redundant check to simplify the code and for clarity.

Signed-off-by: Ralph Campbell <rcampbell@xxxxxxxxxx>

This is based on the current linux tree and is intended for Andrew's mm
tree. There is no rush so it could go into 5.9 but I think it is safe
enough to go into an rc after the patch is reviewed.

Probably shouldn't mark it as mm/hmm if Andrew is going to pick it

OK, I'll mark it as just mm: if I need to repost.

Reviewed-by: Jason Gunthorpe <jgg@xxxxxxxxxxxx>

Jason


Thanks!