Re: [PATCH 2/2] i2c: fsi: Prevent adding adapters for ports without dts nodes

[Andy Shevchenko]

On Mon, Jun 8, 2020 at 7:05 PM Eddie James <eajames@xxxxxxxxxxxxx> wrote:
>
> Ports should be defined in the devicetree if they are to be enabled on
> the system.

...

>         for (port_no = 0; port_no < ports; port_no++) {
>                 np = fsi_i2c_find_port_of_node(dev->of_node, port_no);
> -               if (np && !of_device_is_available(np))

> +               /* Do not add port if it is not described in the device tree */
> +               if (!np)
> +                       continue;

I believe this is redundant, since below will do the same second time.

> +               /* Do not add port if it is described as disabled */
> +               if (!of_device_is_available(np))
>                         continue;

-- 
With Best Regards,
Andy Shevchenko